Spring RTS Engine

Since some players seem to have fps problems with XTA lately, I looked at all changes from 9.728 to 9.729
(please post performance reports in other thread http://springrts.com/phpbb/viewtopic.php?f=48&t=30801)

There are not many changes between 9.728 and 9.729
r346 to r369 on SVN = 23 commits
And some are very likely NOT performance related, like making countdown text smaller by changing one number.
So relevant ones might be these ones:

http://code.google.com/p/xta-springrts/ ... tail?r=349
adds animals.
On maps with no animals, the spawn-gadget disables itself.
The unit scripts are light. (and dont matter if there are no animals)
The textures are small. (64x64 to 128x128, <100 kb)
Unlikely to cause lag. Might maybe cause lag if the small video memory of an old card is already full and that few textures are the last straw?


http://code.google.com/p/xta-springrts/ ... tail?r=355
adds 2 previouslz missing textures (small ones)
see above


http://code.google.com/p/xta-springrts/ ... tail?r=356
bit strange gadget but it only does anything when a new unit is created
should not cause lag


http://code.google.com/p/xta-springrts/ ... tail?r=359
Update gadget handler and some gadgets
No idea what excactly are the differences with callins.lua and gadgets.lua


http://code.google.com/p/xta-springrts/ ... tail?r=364
some new sounds
like the textures, but sounds


http://code.google.com/p/xta-springrts/ ... tail?r=365
http://code.google.com/p/xta-springrts/ ... orders.lua
after commenting out the --return false this gadget now does nothing and could be removed/disabled. (but dont see how it is performance related)
rest does not seem crictial


All in all, none of the changes looks alarming to me, at all.
Except maybe r359 "Update gadget handler" since I do not fully understand this "low level lua".

knorke wrote:http://code.google.com/p/xta-springrts/ ... tail?r=365
http://code.google.com/p/xta-springrts/ ... orders.lua
after commenting out the --return false this gadget now does nothing and could be removed/disabled. (but dont see how it is performance related)
rest does not seem crictial

I created that gadget in the first place: I thought that you should not be able to self-destruct units that aren't finished, because why should they be able to receive orders before they are finished. Like, you can't give them an attack order either.

But then I disabled it by commenting out that part, because it's annoying when you have lost every unit except that one 50% complete vulcan, and can't self-d it (and have to wait like 30 minutes for it to decay).

So I left it in this state, it's easy to enable it or modify it if someone wants. But it could also be just removed.

I'm sure the lag that some people report is unrelated to recent changes in xta, they also reported it in ba IIRC...
Edit, didn't see other thread.