Page 1 of 1
Ground decals can cause spring to crash
Posted: 21 Apr 2008, 03:11
by imbaczek
...and are one of the causes of the dreaded LuaUI crashes, believe it or not. Please turn them off and report if you're experiencing less crashes.
Re: Ground decals can cause spring to crash
Posted: 21 Apr 2008, 09:25
by Tobi
You figured out the bug?
Re: Ground decals can cause spring to crash
Posted: 21 Apr 2008, 09:53
by imbaczek
no, but the replay doesn't crash with ground decals off, and mmgr traces point to grounddecalhandler as the last place that touches the crashing address.
Re: Ground decals can cause spring to crash
Posted: 21 Apr 2008, 18:26
by imbaczek
I'm now 100% positive that turning off ground decals will remedy some of the crashes. Anybody who's experiencing a lot of LuaUI crashes should try this workaround.
Re: Ground decals can cause spring to crash
Posted: 21 Apr 2008, 19:22
by Acidd_UK
Great job finding a workaround! I will be testing that it works

Incidentally, my ground decals was set to 3 before I turned them off.
Re: Ground decals can cause spring to crash
Posted: 21 Apr 2008, 19:37
by MelTraX
That might also explain why some people nearly never crash (like myself) and some crash more often.. Would be pretty cool if that fix eliminates some of them :D..
Re: Ground decals can cause spring to crash
Posted: 21 Apr 2008, 20:32
by imbaczek
http://spring.jobjol.nl/show_file.php?id=993
this is an experimental build with this bug (and only this one) fixed. brave souls out there should try it, the rest is better off turning decals off.
Re: Ground decals can cause spring to crash
Posted: 21 Apr 2008, 22:08
by Acidd_UK
Maybe a candidate for .76 beta 2?
Re: Ground decals can cause spring to crash
Posted: 21 Apr 2008, 22:21
by imbaczek
bug tobi about it. there are also some other bugs which were fixed (like the gray blink bug), those could be backported too without breaking replay compatibility I guess.
Re: Ground decals can cause spring to crash
Posted: 22 Apr 2008, 00:59
by Vadi
MelTraX wrote:That might also explain why some people nearly never crash (like myself) and some crash more often.. Would be pretty cool if that fix eliminates some of them :D..
Same here. LuaUI never crashed for me, and I was wondering why.
Re: Ground decals can cause spring to crash
Posted: 22 Apr 2008, 03:03
by LordMatt
I get errors when I try to compile this on Gutsy 64bit:
scons wrote:rts/Game/PreGame.cpp: In member function 'virtual bool CPreGame::Draw()':
rts/Game/PreGame.cpp:289: error: 'sin' is not a member of 'std'
scons: *** [build/rts/Game/PreGame.o] Error 1
scons: building terminated because of errors.
Re: Ground decals can cause spring to crash
Posted: 22 Apr 2008, 03:19
by lurker
Any hint of 76b2 needs to have the fix to the div0 when units overlap.
Re: Ground decals can cause spring to crash
Posted: 22 Apr 2008, 09:40
by imbaczek
LordMatt: 1. what compiler version? 2. are you sure you did
$ git checkout next
?
lurker:
http://gitorious.org/projects/spring-sv ... /logs/next
this fix is in the tree.
Re: Ground decals can cause spring to crash
Posted: 23 Apr 2008, 01:29
by LordMatt
Compile error seems to be fixed. I'll check for desyncs...
Re: Ground decals can cause spring to crash
Posted: 23 Apr 2008, 02:22
by Beherith
Adding a replay of dsd with a .76b2 testbuild at Lordmatts request. (he crashed out, we ran old version without a hitch)
its 7zipped for 4x smaller file
linky cause board dont allow big files
http://users.hszk.bme.hu/~sp552/080423- ... .76b1-0.7z
Re: Ground decals can cause spring to crash
Posted: 23 Apr 2008, 02:25
by LordMatt
Thanks Beherith. It crashed most of the way in when my licho dropped its nuke weapon on a bunch of zeus and snips. Because I run Gutsy 64bit I don't have any stacktrace. I did not experience any desync over about 30min of 8v8 DSD <insert vomiting smile here> so I would assume it isn't going to desync.
Re: Ground decals can cause spring to crash
Posted: 23 Apr 2008, 18:05
by imbaczek
Thanks for testing and uploading, keep 'em coming.
Re: Ground decals can cause spring to crash
Posted: 23 Apr 2008, 20:37
by imbaczek
I didn't crash for me, does the replay crash for you, Matt?
Re: Ground decals can cause spring to crash
Posted: 24 Apr 2008, 00:10
by reivanen
I had ground decals really high and used to crash alot. Then i turned them off and havent crashed once after that!
Re: Ground decals can cause spring to crash
Posted: 24 Apr 2008, 00:27
by LordMatt
Hmm guess it doesn't crash for me either, however the crash came right as I was giving an order to attack and perhaps the issue was related to giving the order.