Page 1 of 1

Bugfix at unitsync.cpp

Posted: 09 Feb 2008, 21:25
by TradeMark
https://spring.clan-sy.com/svn/spring/t ... itsync.cpp

Code: Select all

				bits >>= 2;
				unsigned char code = bits & 0x3;
->

Code: Select all

				unsigned char code = bits & 0x3;
				bits >>= 2;
yay! and now it reads the minimap correctly 8)

Or i just messed it up while making the code into PHP... but i have seen that same bug before in tasclient, because i remember those minimaps had same kind bug in graphics. Though, i dont understand how this current lobby client reads the minimaps fine.

Re: Bugfix at unitsync.cpp

Posted: 11 Feb 2008, 15:43
by Tobi
Thank you!

I tested it with one of my unitsync python scripts and it indeed fixes that weird visual artefact in the results from GetMinimap().

Committed now.
Though, i dont understand how this current lobby client reads the minimaps fine.
Probably by getting largest possible minimap from unitsync (with the miplevel argument you can get smaller maps too) and downsampling it to correct size. This tends to reduce the artefact.