Ground decals can cause spring to crash

[imbaczek]

...and are one of the causes of the dreaded LuaUI crashes, believe it or not. Please turn them off and report if you're experiencing less crashes.

[Tobi]

You figured out the bug?

[imbaczek]

no, but the replay doesn't crash with ground decals off, and mmgr traces point to grounddecalhandler as the last place that touches the crashing address.

[imbaczek]

I'm now 100% positive that turning off ground decals will remedy some of the crashes. Anybody who's experiencing a lot of LuaUI crashes should try this workaround.

[Acidd_UK]

Great job finding a workaround! I will be testing that it works Incidentally, my ground decals was set to 3 before I turned them off.

[MelTraX]

That might also explain why some people nearly never crash (like myself) and some crash more often.. Would be pretty cool if that fix eliminates some of them :D..

[imbaczek]

http://spring.jobjol.nl/show_file.php?id=993

this is an experimental build with this bug (and only this one) fixed. brave souls out there should try it, the rest is better off turning decals off.

[Acidd_UK]

Maybe a candidate for .76 beta 2?

[imbaczek]

bug tobi about it. there are also some other bugs which were fixed (like the gray blink bug), those could be backported too without breaking replay compatibility I guess.

[Vadi]

That might also explain why some people nearly never crash (like myself) and some crash more often.. Would be pretty cool if that fix eliminates some of them :D..

Same here. LuaUI never crashed for me, and I was wondering why.

[LordMatt]

update: gave in and made a git tree today - http://gitorious.org/projects/spring-sv ... s/mainline branch next

I get errors when I try to compile this on Gutsy 64bit:

rts/Game/PreGame.cpp: In member function 'virtual bool CPreGame::Draw()':
rts/Game/PreGame.cpp:289: error: 'sin' is not a member of 'std'
scons: *** [build/rts/Game/PreGame.o] Error 1
scons: building terminated because of errors.

[lurker]

Any hint of 76b2 needs to have the fix to the div0 when units overlap.

[imbaczek]

LordMatt: 1. what compiler version? 2. are you sure you did
$ git checkout next
?

lurker: http://gitorious.org/projects/spring-sv ... /logs/next

this fix is in the tree.

[LordMatt]

Compile error seems to be fixed. I'll check for desyncs...

[Beherith]

Adding a replay of dsd with a .76b2 testbuild at Lordmatts request. (he crashed out, we ran old version without a hitch)
its 7zipped for 4x smaller file

linky cause board dont allow big files

http://users.hszk.bme.hu/~sp552/080423- ... .76b1-0.7z

[LordMatt]

Thanks Beherith. It crashed most of the way in when my licho dropped its nuke weapon on a bunch of zeus and snips. Because I run Gutsy 64bit I don't have any stacktrace. I did not experience any desync over about 30min of 8v8 DSD <insert vomiting smile here> so I would assume it isn't going to desync.

[imbaczek]

Thanks for testing and uploading, keep 'em coming.

[imbaczek]

I didn't crash for me, does the replay crash for you, Matt?

[reivanen]

I had ground decals really high and used to crash alot. Then i turned them off and havent crashed once after that!

[LordMatt]

Hmm guess it doesn't crash for me either, however the crash came right as I was giving an order to attack and perhaps the issue was related to giving the order.